Add VideoPost message type #145
Conversation
|
@huan ping |
|
Shall we also add like and comments related method in this PR? |
Here #149 , I will merge it into this PR later. |
src/mod.ts
Outdated
| VideoPostPayload, | ||
| } from './schemas/video-post.js' | ||
| import type { | ||
| CommentPayload, |
There was a problem hiding this comment.
How about we reuse Message for comments?
There was a problem hiding this comment.
Do you mean discard Comment class ? Or only reuse MessagePayload for CommentPayload?
There was a problem hiding this comment.
Agree, see: wechaty/wechaty#2245 (comment)
src/schemas/comment.ts
Outdated
| @@ -0,0 +1,7 @@ | |||
| export interface CommentPayload { | |||
There was a problem hiding this comment.
I'd like to consider reusing the Message payload first.
replyId is like we are quoting another message?
Discussion is welcome.
There was a problem hiding this comment.
Agree, show my draft design here:
-
add
MessageType.Comment -
add
quoteIdtoMessagePayloadBase -
methods change
- commentContent() -> comment() // differ with message.say()
- commentRevoke() -> delete() // differ with message.recall()
- commentReply() -> reply()
| @@ -0,0 +1,4 @@ | |||
| export interface ListOption { | |||
| pageSize: number, | |||
| currentPage: number, | |||
There was a problem hiding this comment.
According to the Google Cloud API Design guides, where should we put the next_page_token in this payload?
There was a problem hiding this comment.
Don't agree, next_page_token is in response object. Use pageToken replace currentPage.
And then I would add startAfter, it could make get list more flexibly.
interface ListOption {
pageSize: number,
pageToken?: number,
startAfter?: string,
}There was a problem hiding this comment.
startAfter is not a good name, because the list should be a [start, end) range.
To include the start number, the name of startFrom would be better than startAfter.
There was a problem hiding this comment.
If we want to get the list which start from one specific KEY, how to do with ListOption?
For example, Moment timeline, when we want to get the next page, we should specific the last moment id as the KEY.
Due to the moment timeline will have new moment.
There was a problem hiding this comment.
Question about the type of startAfter
the list should be a [start, end) range.
-
number
Vote for rename it to
startFrom. -
string
Vote for keep
startAfter, due to we only known thestartAfterkey.
|
Merge to #182 |
Related issue: #144