[develop → main] feat: social sign in, token authentication, trainer list, member management, community postlist, membership payment, consultant post #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyeongs
changed the title
suyeongs
changed the title
kyeongraekim
requested changes
Sep 18, 2023
| const getManagement = catchAsync(async (req, res) => { | ||
| const { userId, weekday } = req.query; | ||
| const membership = await managementService.getManagement(userId, weekday); | ||
| res.json(membership); |
There was a problem hiding this comment.
- 해당 membership에 대한 리턴에는 상태코드가 적혀있지 않네요! 상태코드를 함께 꼭 리턴시 함께 줄 수 있도록 수정하여주세요!
kyeongraekim
requested changes
Sep 19, 2023
| userRouter.post('/kakao-sign-in', userController.kakaoSignIn); | ||
| userRouter.post('/kakao-sign-up', userController.kakaoSignUp); | ||
| userRouter.post('/duplicate-nickname', userController.checkDuplicateNickname); | ||
| userRouter.get('/mypage', loginRequired, userController.getMyPage); |
There was a problem hiding this comment.
- RESTful 한 엔드포인트 설계와, 레이어드 패턴 설계 시 mypage와 같은 페이지적 특성을 드러내는 요소로 작성하지 않습니다.
- 즉 유저의 정보를 드러내는 내용이라면 뒤 데이터 자원을 명시하는 영역의 문구가 users/information 정도로 처리될 수 있게 수정해주세요.
There was a problem hiding this comment.
- 해당 내용에 맞게 전체 레이어드패턴에 녹여져있는 myPage라는 워딩을 일괄 수정하여주세요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[GypPT] List of feature implementations to date (230917)