Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better log VM/global backup time duration. #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions backup.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import ovirtsdk4.types as types
import sys
import time
import datetime
from vmtools import VMTools
from config import Config

Expand Down Expand Up @@ -309,6 +310,7 @@ def main(argv):
continue

logger.info("Start backup for: %s", vm_from_list)
vm_time_start = int(time.time())
if config.get_dry_run():
vms_with_failures.remove(vm_from_list)
continue
Expand Down Expand Up @@ -440,18 +442,16 @@ def main(argv):
# Delete the CLONED VM
VMTools.delete_vm(api, config, vm_from_list)

time_end = int(time.time())
time_diff = (time_end - time_start)
time_minutes = int(time_diff / 60)
time_seconds = time_diff % 60

logger.info("Duration: %s:%s minutes", time_minutes, time_seconds)
vm_backup_time = str(datetime.timedelta( seconds = int(time.time()) - vm_time_start ))
logger.info("VM \"%s\" backup duration: %s ", vm_from_list, vm_backup_time )
logger.info("VM exported as %s", vm_clone_name)
logger.info("Backup done for: %s", vm_from_list)
vms_with_failures.remove(vm_from_list)
except Exception as e:
close_and_exit(err_msg=f"!!! Got unexpected exception: {e}")

backup_time = str(datetime.timedelta( seconds = int(time.time()) - time_start ))
logger.info("Overall duration: %s ", backup_time)
logger.info("All backups done")

if vms_with_failures:
Expand Down