Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to use UPal with D7. #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jordansebastian
Copy link

I added a new environment variable to phpunit.xml.dist that indicates which version
of drupal core you intend to use. This is then loaded in drupal_test_case.php and
used to determine how to find bootstrap.inc.

I added a new environment variable to phpunit.xml.dist that indicates which version
of drupal core you intend to use. This is then loaded in drupal_test_case.php and
used to determine how to find bootstrap.inc.
@weitzman
Copy link
Owner

Thanks! I'll have to look into this a bit more - will comment here. Do you have tests running with Drupal 7 now? I'd like to know the full scope of the changes that are needed before I commit to supporting two major versions of Drupal.

I noticed that there are changes to phpunit.xml.dist. You will want to copy the contents of that file to phpunit.xml and revert the .dist file so that you don't accidentally put your password in a pull request :)

@jordansebastian
Copy link
Author

Reverted the phpunit.xml.dist file, but kept the new environment variable that lets you switch between 7 and 8. I'm going to run more tests against core for now and report back.

@jordansebastian
Copy link
Author

The latest commit fixes a few problems I was running into. I'm continuing to test core modules and things seem to be going well. I'll put a list of them here soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants