MIN_VERSION_ghc instead of __GLASGOW_HASKELL__
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that when `ghc` tries to build the plugin with the bootstrap compiler,
`MIN_VERSION_ghc` reports that we are using the GHC API 9.10 but
`__GLASGOW_HASKELL__` reports GHC 9.8. After this change, the plugin builds
during building `ghc`.
Unfortunately, as soon as we try to build anything _with_ the plugin,
compilation fails with
```
libraries/ghc-prim/GHC/CString.hs:1:1: error: [GHC-51294]
Failed to load interface for ‘GHC.Internal.Debug.Trace’.
no unit id matching ‘ghc-internal’ was found
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that when
ghctries to build the plugin with the bootstrap compiler,MIN_VERSION_ghcreports that we are using the GHC API 9.10 but__GLASGOW_HASKELL__reports GHC 9.8. After this change, the plugin builds during buildingghc.Unfortunately, as soon as we try to build anything with the plugin, compilation fails with