Merge pull request #1065 from wellyshen/fix/hmr-not-working

Fix: fix HMR not working by temporary workaround
wellyshen · Apr 28, 2021 · bde2d18 · bde2d18
2 parents b5473d6 + 4741bc4
commit bde2d18
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-cool-starter",
-  "version": "4.3.5",
+  "version": "4.3.6",
   "private": true,
   "description": "A starter boilerplate for a universal web application with the best development experience and best practices.",
   "license": "MIT",

diff --git a/src/client/index.tsx b/src/client/index.tsx
@@ -23,3 +23,9 @@ const render = (Routes: RouteConfig[]) =>
 
 // loadable-component setup
 loadableReady(() => render(routes as RouteConfig[]));
+
+/**
+ * A temporary workaround for Webpack v5 + HMR, why? see this issue: https://github.com/webpack-contrib/webpack-hot-middleware/issues/390
+ */
+// @ts-expect-error
+if (module.hot) module.hot.accept();