Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type mute_signals #392

Closed
wants to merge 2 commits into from
Closed

Type mute_signals #392

wants to merge 2 commits into from

Conversation

sobolevn
Copy link
Member

No description provided.

@sobolevn sobolevn closed this Sep 18, 2023
@sobolevn sobolevn reopened this Sep 18, 2023
from typing_extensions import TypeAlias

_MutedSignals: TypeAlias = Iterator[
Tuple[List[Any], List[Any]], # type: ignore[misc]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIP: can we use Callable? Maybe we ParamSpec?



@contextmanager
def mute_migrate_signals():
def mute_migrate_signals() -> MutedSignals:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def mute_migrate_signals() -> MutedSignals:
def mute_migrate_signals() -> _MutedSignals:

@sobolevn sobolevn closed this Jun 3, 2024
@sobolevn sobolevn deleted the sobolevn-patch-1 branch June 28, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants