use exit code rather than stderr contents to determine if command exe…

…cution does not succeed
weng-lab · Oct 22, 2023 · 643b1ff · 643b1ff
1 parent e50effc
commit 643b1ff
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -13,7 +13,7 @@ plugins {
 }
 
 group = "io.krews"
-version = "0.14.12"
+version = "0.14.13"
 
 repositories {
     maven { setUrl("https://dl.bintray.com/kotlin/kotlin-eap") }

diff --git a/src/main/kotlin/krews/misc/Shell.kt b/src/main/kotlin/krews/misc/Shell.kt
@@ -23,8 +23,9 @@ class CommandExecutor(private val sshConfig: SshConfig? = null) {
         log.info { "Command results:\n$result" }
 
         val error = process.errorStream.reader().readText()
-        if (error.isNotBlank()) throw Exception("Encountered error during command execution: $error")
+        val exitCode = process.waitFor()
+        if (exitCode != 0) throw Exception("Encountered error during command execution: $error")
         return result
     }
 
-}
+}