Add Package.swift file to build Sweet B as a Swift package #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmastenbrook
suggested changes
Apr 25, 2022
Comment on lines
+47
to
+48
| After adding this package to your target's dependencies, you can write | ||
| stuff like this: |
There was a problem hiding this comment.
Suggested change
| After adding this package to your target's dependencies, you can write | |
| stuff like this: | |
| After adding this package to your target's dependencies, you use it | |
| like this: |
|
|
||
| var hkdf = sb_hkdf_state_t() | ||
| sb_hkdf_extract(&hkdf, salt, salt.count, ikm, ikm.count) | ||
|
|
There was a problem hiding this comment.
Is it possible to convert this into an actual test that we could run in CI? I'm a complete novice when it comes to Swift, but it does seem like you can add a test target to a Swift package. Ideally I would love to see an example of using each of the major functions as a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Sweet B to be fetched and built as a Swift package.
This avoids the need to embed the Sweet B sources (or use a git submodule) when using Sweet B in a Swift-based project.