Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CImg to 179 because it fixes leaking file descriptors #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

route
Copy link

@route route commented Mar 1, 2017

I see your archive of pHash-0.9.6.tar.gz has Cimg.h included. I think it's good idea in general to decouple it from there and copy when needed when compile. Also it's an old version of CImg which has a bug of leaking file descriptors resulting in Too many open files (Errno::EMFILE) which was fixed in 179

@route
Copy link
Author

route commented Jun 1, 2017

Any feedback would have been much appreciated

@westonplatter
Copy link
Owner

@route looks like the tests are failing. Those would be worth fixing.

@route
Copy link
Author

route commented Jun 2, 2017

Yea I'll fix them, but over all does it seem like a good idea?

@westonplatter westonplatter changed the title Update CImg to 179 because it fixes leaking file descriptors chore: Update CImg to 179 because it fixes leaking file descriptors Mar 5, 2023
ryoga-chan added a commit to ryoga-chan/phashion that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants