Field flow: Keep URL params matching HTML attributes #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricDunsworth
commented
Jul 26, 2024
|
Pre-approved upon successful review. |
EricDunsworth
force-pushed
the
fieldflow-url-params-matching-html-attrs
branch
from
0c4a4fb
to
770559d
Compare
duboisp
previously requested changes
Aug 12, 2024
EricDunsworth
had a problem deploying
to
github-ci
GitHub Actions
Failure
EricDunsworth
force-pushed
the
fieldflow-url-params-matching-html-attrs
branch
from
00c6715
to
28b6da8
Compare
EricDunsworth
temporarily deployed
to
github-ci
GitHub Actions
Inactive
|
FWIW I retested locally with @duboisp's suggested change and it still worked fine 💯. |
|
Pre-approved upon review and local testing. |
When field flow's redirect (redir) action is used, submitting causes the plugin to "transform" the currently-selected dropdown option's URL parameters into hidden input elements. The inputs are created by passing "raw" HTML strings to the jQuery object. That setup used to play nicely with URL parameters whose keys corresponded to the names of HTML attributes (e.g. lang=anything). But it stopped working when wet-boew/wet-boew#9210 introduced DOMPurify into WET's jQuery 2.x implementation. Why? Because DOMPurify's sanitize() method filters-out name="[any HTML attribute name]" to prevent potential DOM clobbering attacks (see cure53/DOMPurify#980). End result is that jQuery ultimately returns name-less inputs to the plugin, which in turn causes affected parameters to go missing. This fixes it by using "pure" JavaScript (instead of jQuery) to create the inputs. Also adds a query string example to the redirection demo (with a mix of key naming schemes). Fixes wet-boew#2406. Co-authored-by: Pierre Dubois <[email protected]>
EricDunsworth
force-pushed
the
fieldflow-url-params-matching-html-attrs
branch
from
28b6da8
to
734faf9
Compare
EricDunsworth
temporarily deployed
to
github-ci
GitHub Actions
Inactive
|
Rebased, updated modified dates and force-pushed. This wasn't running into any merge conflicts, but since it hadn't been tested by any project maintainers yet... I figured it'd make sense to rebase to make it node 20-friendly. |
Garneauma
approved these changes
Aug 28, 2024
|
Thank you all for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When field flow's redirect (
redir) action is used, submitting causes the plugin to "transform" the currently-selected dropdownoption's URL parameters into hiddeninputelements. Theinputs are created by passing "raw" HTML strings to the jQuery object.That setup used to play nicely with URL parameters whose keys corresponded to the names of HTML attributes (e.g.
lang=anything). But it stopped working when wet-boew/wet-boew#9210 introduced DOMPurify into WET's jQuery 2.x implementation. Why? Because DOMPurify'ssanitize()method filters-outname="[any HTML attribute name]"to prevent potential DOM clobbering attacks (see cure53/DOMPurify#980). End result is that jQuery ultimately returnsname-lessinputs to the plugin, which in turn causes affected parameters to go missing.This fixes it by using "pure" JavaScript (instead of jQuery) to create the
inputs. Also adds a query string example to the redirection demo (with a mix of key naming schemes).Fixes #2406.