Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

889 ExitScript Exempt Attribute #903

Merged
merged 3 commits into from
Jul 17, 2023
Merged

889 ExitScript Exempt Attribute #903

merged 3 commits into from
Jul 17, 2023

Conversation

ahmad-shahid
Copy link
Contributor

No description provided.

@ahmad-shahid ahmad-shahid linked an issue Jul 17, 2023 that may be closed by this pull request
@plup2 plup2 self-assigned this Jul 17, 2023
@@ -76,6 +76,7 @@ <h2>Implementation</h2>
<li><code class="wb-prettify">displayModalForNewWindow</code>: If set to true, will not display modal for links that open in new window</li>

</ul>
<p>The attribute <code class="wb-prettify">cdts-exitscript-disabled</code> can be added to individual links to exempt it from exit script.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that the french is good, but in english, shouldn't it be "... to exempt them from..." ? (applies to gcweb as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, true!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@plup2 plup2 merged commit a1e0502 into master Jul 17, 2023
6 checks passed
@plup2 plup2 deleted the 889-exit-script-url branch July 17, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit Script URL
2 participants