docs(metaMask): enhance documentation for MetaMask Connector features… #4511
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and usage - Added a description of the MetaMask Connector's capabilities, including wallet connection management, support for multiple chains, and compatibility with browser and mobile environments. - Clarified the distinction between the MetaMask Connector and the Injected Connector. - Included a link to the MetaMask SDK documentation for further reference.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tmm
reviewed
Jan 22, 2025
| @@ -92,8 +90,6 @@ const connector = metaMask({ | |||
|
|
|||
| ### headless | |||
|
|
|||
| `boolean | undefined` | |||
| @@ -63,8 +63,6 @@ const connector = metaMask({ | |||
|
|
|||
| ### logging | |||
|
|
|||
| `SDKLoggingOptions | undefined` | |||
| @@ -41,8 +43,6 @@ Check out the [MetaMask SDK docs](https://docs.metamask.io/wallet/connect/3rd-pa | |||
|
|
|||
| ### dappMetadata | |||
|
|
|||
| `DappMetadata | undefined` | |||
There was a problem hiding this comment.
Let's keep these types around (convention we use throughout the docs)
| @@ -8,6 +8,8 @@ const connectorsPackageName = 'wagmi/connectors' | |||
|
|
|||
| Connector for [MetaMask SDK](https://github.com/MetaMask/metamask-sdk). | |||
|
|
|||
| The MetaMask Connector helps you manage wallet connections in your React applications. It supports essential features like connecting, disconnecting, and handling multiple chains, while maintaining compatibility with browser and mobile environments. You can choose between the MetaMask Connector and the Injected Connector—but keep in mind that using the Injected Connector limits your app to the MetaMask browser extension only. | |||
There was a problem hiding this comment.
Since this is a shared page for the VanillaJS, Vue, and React docs, let's keep it basic and remove the mention of React.
Suggested change
| The MetaMask Connector helps you manage wallet connections in your React applications. It supports essential features like connecting, disconnecting, and handling multiple chains, while maintaining compatibility with browser and mobile environments. You can choose between the MetaMask Connector and the Injected Connector—but keep in mind that using the Injected Connector limits your app to the MetaMask browser extension only. | |
| Check out the [MetaMask SDK docs](https://docs.metamask.io/wallet/connect/metamask-sdk/javascript) for more information. |
Comment on lines
+119
to
+122
|
|
||
| ## MetaMask SDK Docs | ||
|
|
||
| Check out the [MetaMask SDK docs](https://docs.metamask.io/wallet/connect/metamask-sdk/javascript/react/) for more information. |
There was a problem hiding this comment.
Added further up instead
Suggested change
| ## MetaMask SDK Docs | |
| Check out the [MetaMask SDK docs](https://docs.metamask.io/wallet/connect/metamask-sdk/javascript/react/) for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made based on feedback from the MetaMask team: