Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ProxyUseFdPass to ssh #6103

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Add support for ProxyUseFdPass to ssh #6103

merged 3 commits into from
Sep 14, 2024

Conversation

loops
Copy link
Contributor

@loops loops commented Sep 7, 2024

As per #6093

Utilizes a small, 3rd party crate (passfd) which allows the proxy
command to return a connected FD, instead of copying data.
This support is not implemented on Microsoft, and the crate
was marked as a dependency on unix-like systems only.

Some, associated code cleanup and reorg changes are included
in a trailing commit, and can be safely dropped if not wanted.

This allows the ProxyUseFDpass ssh config option, to be
used on Linux and Mac OS.  This was requested in
enhancement issue wez#6093
It doesn't make much sense to pass this value, especially
after adding the ProxyUseFDpass functionality, which
accesses the config directly anyway.
Copy link
Owner

@wez wez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I have comments about the cleanup portion of this, but the rest seems good to me!

wezterm-ssh/src/config.rs Outdated Show resolved Hide resolved
@wez wez merged commit c3fd4b0 into wez:main Sep 14, 2024
16 of 17 checks passed
wez added a commit that referenced this pull request Sep 14, 2024
@wez
Copy link
Owner

wez commented Sep 14, 2024

Thanks!

@cpuguy83
Copy link

Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants