Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify download using sha1 checksum, if possible #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stisti
Copy link

@stisti stisti commented Jul 14, 2015

Download also SHASUMS.txt file and check the downloaded tar package is good.

Apparently the older node versions do not have a SHASUMS.txt file, so do not
fail, just warn, if the SHASUMS.txt cannot be downloaded.

@stisti stisti force-pushed the verified_install branch 2 times, most recently from a101579 to 68c391f Compare July 14, 2015 20:40
@cronopio
Copy link
Collaborator

Hi

Thanks for the contribution, really appreciated. Would you try to rebase your branch to the latest master?

Also we added io.js support recently so not sure if we can do the same for io.js releases

Thanks!

@stisti
Copy link
Author

stisti commented Aug 11, 2015

Sure, will do.

2015-08-10 22:52 GMT+03:00 Daniel Aristizabal [email protected]:

Hi

Thanks for the contribution, really appreciated. Would you try to rebase
your branch to the latest master?

Also we added io.js support recently so not sure if we can do the same
for io.js releases

Thanks!


Reply to this email directly or view it on GitHub
#23 (comment).

Download also SHASUMS256.txt file and check the downloaded tar package is good.

Apparently the older node versions do not have a checksum file, so do not
fail, just warn, if the checksum file cannot be downloaded.
@stisti
Copy link
Author

stisti commented Aug 15, 2015

Here you go. I switched to using sha256 because that's what iojs seems to use.

@cronopio
Copy link
Collaborator

@stisti Aweomse. Thank you so much for taking the time. I'll review and merge ASAP.

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants