Added filter functionality to the weight chart and the weight card on the dashboard #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandgeider
reviewed
Jul 5, 2024
| variant={activeFilter === 'all' ? 'contained' : 'outlined'} | ||
| onClick={() => handleFilterClick('all')} | ||
| > | ||
| All |
There was a problem hiding this comment.
can you mark the texts as translatable? you just need to add a key to public/locales/en/translation.json and then you can use it with t('')
rolandgeider
reviewed
Jul 5, 2024
| @@ -1 +1,223 @@ | |||
| ../../../public/locales/en/translation.json | |||
There was a problem hiding this comment.
ah, this was the symlink that was making problems. I'm not sure what a goof solution for this is, but could you revert this change? You can replace the symlink again, just not commit it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements several enhancements and improvements to the weight chart filtering functionality and the user interface of the filter buttons in the WeightFilter, BodyWeight, and WeightCard components.