UI for flexible routines #975
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # yarn.lock
This is only used to show the current workout day, and is not edited in any way
This is only used when submitting exercises, and we will probably need a new one that simply handles known exercises throughout the application
# Conflicts: # src/services/workoutLogs.test.ts
This is still not a 100% perfect solution, but it should be enough
This is what the user is more probably going to do anyway
This allows to compare the planned values vs what was actually logged
If there are planned min and max values, the logged value is green as long as it is between those. Also move the logic to an external function so that this can be more easily tested
This makes it easier to work with them, such as during comparisons
Note that this is still not a perfect solution, since javascript helpfully parses "42ggg" to "42" and doesn't throw an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.