Run docker login in each docker build job

docker login has a logout step at the end of the job. This explains the insufficient privileges error displayed in the recent builds
whalebrew · Sep 22, 2023 · 75bd776 · 75bd776
1 parent 4269379
commit 75bd776
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 23 deletions.
diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
@@ -1,4 +1,4 @@
-name: "build-images"
+name: "build-all-images"
 on: # rebuild any PRs and main branch changes
   pull_request:
   push:
@@ -14,23 +14,7 @@ jobs:
     steps:
     - run: echo success
 
-  login:
-    runs-on: ubuntu-latest
-    steps:
-    - name: Login to Docker Hub
-      uses: docker/login-action@v3
-      with:
-        username: whalebrewci
-        password: ${{ secrets.DOCKER_HUB_PASSWORD }}
-    - name: Login to Docker Hub
-      uses: docker/login-action@v3
-      with:
-        registry: ghcr.io
-        username: ${{ github.actor }}
-        password: ${{ secrets.GITHUB_TOKEN }}
   docker-build:
-    needs:
-    - login
     runs-on: ubuntu-latest
     strategy:
         fail-fast: false
@@ -118,6 +102,17 @@ jobs:
             - youtube-dl
             - yq
     steps:
+    - name: Login to Docker Hub
+      uses: docker/login-action@v3
+      with:
+        username: whalebrewci
+        password: ${{ secrets.DOCKER_HUB_PASSWORD }}
+    - name: Login to Docker Hub
+      uses: docker/login-action@v3
+      with:
+        registry: ghcr.io
+        username: ${{ github.actor }}
+        password: ${{ secrets.GITHUB_TOKEN }}
     - uses: actions-go/modified@master
       id: is-modified
       with:

diff --git a/.github/workflows/pushimage.yaml b/.github/workflows/pushimage.yaml
@@ -13,7 +13,7 @@ on:
         type: string
 
 jobs:
-  login:
+  docker-build:
     runs-on: ubuntu-latest
     steps:
     - name: Login to Docker Hub
@@ -27,11 +27,6 @@ jobs:
         registry: ghcr.io
         username: ${{ github.actor }}
         password: ${{ secrets.GITHUB_TOKEN }}
-  docker-build:
-    needs:
-    - login
-    runs-on: ubuntu-latest
-    steps:
     - uses: actions/checkout@v1
     - run: |
         echo ::group::build image ${{ inputs.image }}:latest