Implementing all Hyperion v2 calls #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafuga
changed the title
dafuga
force-pushed
the
dafuga-initial-commits
branch
4 times, most recently
from
f83709a
to
d148552
Compare
dafuga
force-pushed
the
dafuga-initial-commits
branch
from
d148552
to
f26d558
Compare
aaroncox
reviewed
Sep 20, 2023
src/endpoints.ts
Outdated
| } | ||
|
|
||
| async get_voters( | ||
| producer?: string, |
There was a problem hiding this comment.
Should we make all the inputs be typed, e.g. this one being a NameType?
aaroncox
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.