Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example that rejects promises from in parallel #10541

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Fix example that rejects promises from in parallel #10541

merged 2 commits into from
Aug 15, 2024

Conversation

domenic
Copy link
Member

@domenic domenic commented Aug 2, 2024 •
edited by pr-preview bot
Loading

annevk
annevk reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these examples have a further "Resolve" step that also need a task wrapper.

@domenic
Copy link
Member Author

domenic commented Aug 14, 2024

And that's why we do code review! Thanks, fixed.

@domenic domenic merged commit 3ed9f71 into main Aug 15, 2024
2 checks passed
@domenic domenic deleted the fix-parallel-example branch August 15, 2024 01:06
dontcallmedom added a commit to dontcallmedom/html that referenced this pull request Aug 23, 2024
@dontcallmedom
[editorial] Add a missing to in parallel example
90c3d9b 
patch to whatwg#10541
@dontcallmedom dontcallmedom mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example in parallelism section needs to "queue a task" to handle the promise
2 participants
@domenic @annevk