Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nova 5.0 Support #530

Merged
merged 20 commits into from
Jan 18, 2025
Merged

Nova 5.0 Support #530

merged 20 commits into from
Jan 18, 2025

Conversation

bashgeek
Copy link
Contributor

@bashgeek bashgeek commented Dec 16, 2024 •
edited
Loading

Initial attempt at adding Nova 5.0 support.

Builds fine, no more errors. But ran into some upstream vendor JS errors now and don't have time to continue here for now. If anyone else wants to continue or attempt in the meantime, this should give a good starting point.

Fyi, this will definitely be a breaking change and drop Nova 4.0 support, caution advised.

Would fix #529

crynobone
crynobone suggested changes Dec 23, 2024
View reviewed changes
resources/js/components/FormGroup.vue Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
crynobone
crynobone reviewed Dec 23, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@bashgeek
Copy link
Contributor Author

@crynobone thanks for you help!

However, the errors coming from vendor.js remain and I still cannot see what's wrong here, maybe another pair of eyes sees it:

TypeError: e is undefined
    pi https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    r https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    pi https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    ja https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    I https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    L https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    w https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    F https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    P https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    V https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    w https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    _ https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    V https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    w https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    _ https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    M https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    E https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    w https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    l https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    run https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    runIfDirty https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    gn https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    In https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    promise callback*Sn https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    _n https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    scheduler https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    trigger https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    Ce https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    rt https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    push https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    addGroup https://nova5.test/nova-api/scripts/nova-flexible-content:2
    0 https://nova5.test/nova-api/scripts/nova-flexible-content:2
    gn https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    wn https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    qi https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    addGroup https://nova5.test/nova-api/scripts/nova-flexible-content:2
    onClick https://nova5.test/nova-api/scripts/nova-flexible-content:2
    gn https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    wn https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    n https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    cs https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    ds https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    patchProp https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    A https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    E https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    w https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    B https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    A https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    E https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    w https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    B https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    V https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    w https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    B https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    A https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    E https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    w https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    B https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    A https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    E https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    w https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    _ https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    M https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    E https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    w https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    l https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    run https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    runIfDirty https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    gn https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
    In https://nova5.test/vendor/nova/vendor.js?id=b51081d96a08fc9fb5fe461b8565ac0d:2
vendor.js:2:1139429

@crynobone
Copy link
Contributor

@bashgeek can you prepare an example Nova Workbench so I can test this locally, I don't use this package and not familiar with how this can be used.

@bashgeek
Copy link
Contributor Author

bashgeek commented Dec 24, 2024 •
edited
Loading

@bashgeek can you prepare an example Nova Workbench so I can test this locally, I don't use this package and not familiar with how this can be used.

@crynobone Sure, here: https://github.com/bashgeek/laravel-nova-flexible-test/
I added a test field "content" to the users, which causes the same error as mentioned above when trying to add a section.

Thanks for taking a look at this!

@crynobone
Copy link
Contributor

Submit a PR to fix the issue: blendbyte#1

@bashgeek bashgeek marked this pull request as ready for review December 24, 2024 14:08
@bashgeek
Copy link
Contributor Author

bashgeek commented Dec 24, 2024 •
edited
Loading

Thanks to @crynobone this is no longer a draft and works fine for me now.

Please note: Breaking change! This will break Nova 4.0 compatibility and only work with Nova 5.0, so please branch out and release a new major version for this.

Furthermore, this also adds workbench support.

@MattLoyeD
Copy link

Any news ? Really looking toward updating to Nova 5 and this is our last remaining package to update :)

@voidgraphics
Copy link
Member

I'll take a look this week-end, thanks @bashgeek and @crynobone!

@voidgraphics
Copy link
Member

Thanks for the PR, looking good on my end, just a couple UI fixes to do but I'll handle those on master because I cannot push to your branch.

@voidgraphics voidgraphics merged commit 8393ddd into whitecube:master Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crynobone crynobone crynobone requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nova v5 Support
4 participants
@bashgeek @crynobone @MattLoyeD @voidgraphics