Skip to content

Commit

Permalink
Merge branch 'head_unity2019'
Browse files Browse the repository at this point in the history
  • Loading branch information
whiteflare committed May 24, 2024
2 parents 8ac26d0 + 2ef695d commit 02ce0f8
Show file tree
Hide file tree
Showing 91 changed files with 1,436 additions and 706 deletions.
1,286 changes: 1,286 additions & 0 deletions CHANGELOG.md

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions CHANGELOG.md.meta

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions Editor/WF_Dictionary.cs
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@ private static bool HasPropertyPrefix(Material mat, string prefix)

// その他の機能
new WFShaderFunction("BKT", "BKT", "BackFace Texture"),
new WFShaderFunction("CHM", "CHM", "3ch Color Mask"),
new WFShaderFunction("CGR", "CGR", "Gradient Map"),
new WFShaderFunction("CLC", "CLC", "Color Change"),
new WFShaderFunction("LME", "LME", "Lame"),
Expand All @@ -266,7 +265,7 @@ private static bool HasPropertyPrefix(Material mat, string prefix)
new WFShaderFunction("GL", "GL", "Lit & Lit Advance", (self, mat) => HasPropertyPrefix(mat, "_GL")),

// 以下のプレフィックスは昔使っていたものなので使わない方が良い
// GB, GF, GR, FG, BK, CH, CL, LM, OL, DF, GI, RF
// GB, GF, GR, FG, BK, CH, CL, LM, OL, DF, GI, RF, CHM
};

/// <summary>
Expand Down Expand Up @@ -489,7 +488,6 @@ private static Dictionary<string, WFCustomKeywordSetting> ToWFCustomKeywordSetti
new WFI18NTranslation("MT", "Smoothness", "滑らかさ"),
new WFI18NTranslation("MT", "Monochrome Reflection", "モノクロ反射"),
new WFI18NTranslation("MT", "Specular", "スペキュラ反射"),
new WFI18NTranslation("MT", "MetallicMap Type", "Metallicマップの種類"),
new WFI18NTranslation("MT", "MetallicSmoothnessMap Texture", "MetallicSmoothnessマップ"),
new WFI18NTranslation("MT", "RoughnessMap Texture", "Roughnessマップ"),
new WFI18NTranslation("MT", "2nd CubeMap Blend", "キューブマップ混合タイプ"),
Expand Down Expand Up @@ -784,6 +782,9 @@ private static Dictionary<string, WFCustomKeywordSetting> ToWFCustomKeywordSetti
new WFI18NTranslation(WFMessageButton.Cleanup, "マテリアルから不要データを削除"),
new WFI18NTranslation(WFMessageButton.ApplyTemplate, "テンプレートから適用"),
new WFI18NTranslation(WFMessageButton.SaveTemplate, "テンプレートとして保存"),

// 今は未使用
new WFI18NTranslation("MT", "MetallicMap Type", "Metallicマップの種類"),
};


Expand Down Expand Up @@ -848,7 +849,6 @@ private static Dictionary<string, WFCustomKeywordSetting> ToWFCustomKeywordSetti
new WFI18NTranslation("MT", "Smoothness", "부드럽게"),
new WFI18NTranslation("MT", "Monochrome Reflection", "흑백 반사"),
new WFI18NTranslation("MT", "Specular", "스펙큘러"),
new WFI18NTranslation("MT", "MetallicMap Type", "Metallic맵 타입"),
new WFI18NTranslation("MT", "MetallicSmoothnessMap Texture", "MetallicSmoothness맵"),
new WFI18NTranslation("MT", "RoughnessMap Texture", "Roughness맵"),
new WFI18NTranslation("MT", "2nd CubeMap Blend", "큐브 맵 혼합"),
Expand Down Expand Up @@ -1004,10 +1004,12 @@ private static Dictionary<string, WFCustomKeywordSetting> ToWFCustomKeywordSetti
new WFI18NTranslation(WFMessageText.DgMigrationAuto, "UnlitWF의 버전이 갱신되었습니다. \n프로젝트 내의 머티리얼을 검사하여 최신 머티리얼값으로 갱신하시겠습니까?"),
new WFI18NTranslation(WFMessageText.DgMigrationManual, "프로젝트 내의 머티리얼을 검사하여 최신 머티리얼값으로 갱신하시겠습니까?"),


new WFI18NTranslation(WFMessageButton.Cleanup, "머티리얼 내에서 불필요한 데이터 삭제"),
new WFI18NTranslation(WFMessageButton.ApplyTemplate, "템플릿부터 적용"),
new WFI18NTranslation(WFMessageButton.SaveTemplate, "템플릿으로 저장"),

// 今は未使用
new WFI18NTranslation("MT", "MetallicMap Type", "Metallic맵 타입"),
};
}

Expand Down
19 changes: 0 additions & 19 deletions Editor/WF_ShaderToolWindow.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ static class WFMenu
public const string PATH_ASSETS = "Assets/UnlitWF Material Tools/";
public const string PATH_TOOLS = "Tools/UnlitWF/";
public const string PATH_MATERIAL = "CONTEXT/Material/";
public const string PATH_GAMEOBJECT = "GameObject/";

#if WF_ML_JP
public const string ASSETS_AUTOCNV_01 = PATH_ASSETS + "UnlitWF のマテリアルに変換する/InternalErrorShaderのみ";
Expand Down Expand Up @@ -70,8 +69,6 @@ static class WFMenu
public const string MATERIAL_AUTOCNV = PATH_MATERIAL + "UnlitWF のマテリアルに変換する";
public const string MATERIAL_DEBUGVIEW = PATH_MATERIAL + "DebugView シェーダに切り替える";
public const string MATERIAL_CNGMOBILE = PATH_MATERIAL + "モバイル向けシェーダに変換する";

public const string GAMEOBJECT_CREANUP = PATH_GAMEOBJECT + "UnlitWFマテリアルのクリンナップ";
#else
public const string ASSETS_AUTOCNV_01 = PATH_ASSETS + "Convert UnlitWF Material/Only InternalErrorShader";
public const string ASSETS_AUTOCNV_02 = PATH_ASSETS + "Convert UnlitWF Material/Exclude Unity-builtin Shaders";
Expand Down Expand Up @@ -99,8 +96,6 @@ static class WFMenu
public const string MATERIAL_AUTOCNV = PATH_MATERIAL + "Convert UnlitWF Material";
public const string MATERIAL_DEBUGVIEW = PATH_MATERIAL + "Switch WF_DebugView Shader";
public const string MATERIAL_CNGMOBILE = PATH_MATERIAL + "Change Mobile shader";

public const string GAMEOBJECT_CREANUP = PATH_GAMEOBJECT + "CleanUp UnlitWF Material Property";
#endif

public const string TOOLS_LNG_EN = PATH_TOOLS + "Menu Language Change To English";
Expand Down Expand Up @@ -554,20 +549,6 @@ private static void OpenWindowFromMenu_Asset()
GetWindow<ToolCreanUpWindow>("UnlitWF/CleanUp material property");
}

[MenuItem(WFMenu.GAMEOBJECT_CREANUP, priority = 10)] // GameObject/配下は priority の扱いがちょっと特殊
private static void OpenWindowFromMenu_GameObject()
{
if (Selection.GetFiltered<GameObject>(SelectionMode.Unfiltered).Length == 0)
{
ToolCommon.SetMaterials(new MaterialSeeker().GetAllMaterialsInScene().ToArray());
}
else
{
ToolCommon.SetSelectedMaterials(MatSelectMode.FromScene);
}
GetWindow<ToolCreanUpWindow>("UnlitWF/CleanUp material property");
}

[MenuItem(WFMenu.TOOLS_CREANUP, priority = WFMenu.PRI_TOOLS_CREANUP)]
private static void OpenWindowFromMenu_Tool()
{
Expand Down
2 changes: 1 addition & 1 deletion Shaders/Unlit_WF_DebugView.shader
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Shader "UnlitWF/Debug/WF_DebugView" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_QuestSupported ("True", Float) = 0
Expand Down
2 changes: 1 addition & 1 deletion Shaders/Unlit_WF_FakeFur_FurOnly_Mix.shader
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ Shader "UnlitWF/WF_FakeFur_FurOnly_Mix" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_VRCFallback ("Hidden", Float) = 0
Expand Down
2 changes: 1 addition & 1 deletion Shaders/Unlit_WF_FakeFur_FurOnly_TransCutout.shader
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ Shader "UnlitWF/WF_FakeFur_FurOnly_TransCutout" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_VRCFallback ("Hidden", Float) = 0
Expand Down
2 changes: 1 addition & 1 deletion Shaders/Unlit_WF_FakeFur_FurOnly_Transparent.shader
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ Shader "UnlitWF/WF_FakeFur_FurOnly_Transparent" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_VRCFallback ("Hidden", Float) = 0
Expand Down
4 changes: 2 additions & 2 deletions Shaders/Unlit_WF_FakeFur_Mix.shader
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ Shader "UnlitWF/WF_FakeFur_Mix" {
_TR_Enable ("[TR] Enable", Float) = 0
[HDR]
_TR_Color ("[TR] Rim Color", Color) = (0.8, 0.8, 0.8, 1)
[WF_Enum(UnlitWF.BlendModeTR,ADD,ALPHA,ADD_AND_SUB,MUL)]
[WF_Enum(UnlitWF.BlendModeTR,ADD,ALPHA,ADD_AND_SUB)]
_TR_BlendType ("[TR] Blend Type", Float) = 0
_TR_Width ("[TR] Width", Range(0, 1)) = 0.1
_TR_Feather ("[TR] Feather", Range(0, 1)) = 0.05
Expand Down Expand Up @@ -207,7 +207,7 @@ Shader "UnlitWF/WF_FakeFur_Mix" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_FallBack ("UnlitWF/UnToon_Mobile/WF_UnToon_Mobile_Opaque", Float) = 0
Expand Down
4 changes: 2 additions & 2 deletions Shaders/Unlit_WF_FakeFur_TransCutout.shader
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ Shader "UnlitWF/WF_FakeFur_TransCutout" {
_TR_Enable ("[TR] Enable", Float) = 0
[HDR]
_TR_Color ("[TR] Rim Color", Color) = (0.8, 0.8, 0.8, 1)
[WF_Enum(UnlitWF.BlendModeTR,ADD,ALPHA,ADD_AND_SUB,MUL)]
[WF_Enum(UnlitWF.BlendModeTR,ADD,ALPHA,ADD_AND_SUB)]
_TR_BlendType ("[TR] Blend Type", Float) = 0
_TR_Width ("[TR] Width", Range(0, 1)) = 0.1
_TR_Feather ("[TR] Feather", Range(0, 1)) = 0.05
Expand Down Expand Up @@ -203,7 +203,7 @@ Shader "UnlitWF/WF_FakeFur_TransCutout" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_FallBack ("UnlitWF/UnToon_Mobile/WF_UnToon_Mobile_Opaque", Float) = 0
Expand Down
4 changes: 2 additions & 2 deletions Shaders/Unlit_WF_FakeFur_Transparent.shader
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ Shader "UnlitWF/WF_FakeFur_Transparent" {
_TR_Enable ("[TR] Enable", Float) = 0
[HDR]
_TR_Color ("[TR] Rim Color", Color) = (0.8, 0.8, 0.8, 1)
[WF_Enum(UnlitWF.BlendModeTR,ADD,ALPHA,ADD_AND_SUB,MUL)]
[WF_Enum(UnlitWF.BlendModeTR,ADD,ALPHA,ADD_AND_SUB)]
_TR_BlendType ("[TR] Blend Type", Float) = 0
_TR_Width ("[TR] Width", Range(0, 1)) = 0.1
_TR_Feather ("[TR] Feather", Range(0, 1)) = 0.05
Expand Down Expand Up @@ -200,7 +200,7 @@ Shader "UnlitWF/WF_FakeFur_Transparent" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_FallBack ("UnlitWF/UnToon_Mobile/WF_UnToon_Mobile_Opaque", Float) = 0
Expand Down
2 changes: 1 addition & 1 deletion Shaders/Unlit_WF_Gem_Opaque.shader
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ Shader "UnlitWF/WF_Gem_Opaque" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_FallBack ("UnlitWF/UnToon_Mobile/WF_UnToon_Mobile_Opaque", Float) = 0
Expand Down
2 changes: 1 addition & 1 deletion Shaders/Unlit_WF_Gem_Transparent.shader
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ Shader "UnlitWF/WF_Gem_Transparent" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_FallBack ("UnlitWF/UnToon_Mobile/WF_UnToon_Mobile_Transparent", Float) = 0
Expand Down
2 changes: 1 addition & 1 deletion Shaders/Unlit_WF_Grass_TransCutout.shader
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Shader "UnlitWF/WF_Grass_TransCutout" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_QuestSupported ("True", Float) = 0
Expand Down
2 changes: 1 addition & 1 deletion Shaders/Unlit_WF_Particle_Addition.shader
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Shader "UnlitWF/WF_Particle_Addition" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_QuestSupported ("True", Float) = 0
Expand Down
2 changes: 1 addition & 1 deletion Shaders/Unlit_WF_Particle_Multiply.shader
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Shader "UnlitWF/WF_Particle_Multiply" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_QuestSupported ("True", Float) = 0
Expand Down
2 changes: 1 addition & 1 deletion Shaders/Unlit_WF_Particle_Opaque.shader
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Shader "UnlitWF/WF_Particle_Opaque" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_QuestSupported ("True", Float) = 0
Expand Down
2 changes: 1 addition & 1 deletion Shaders/Unlit_WF_Particle_TransCutout.shader
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Shader "UnlitWF/WF_Particle_TransCutout" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_QuestSupported ("True", Float) = 0
Expand Down
2 changes: 1 addition & 1 deletion Shaders/Unlit_WF_Particle_Transparent.shader
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Shader "UnlitWF/WF_Particle_Transparent" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_QuestSupported ("True", Float) = 0
Expand Down
4 changes: 1 addition & 3 deletions Shaders/Unlit_WF_UnToon_Custom_ClearCoat_Addition.shader
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ Shader "UnlitWF/Custom/WF_UnToon_Custom_ClearCoat_Addition" {
_MT_Monochrome ("[MT] Monochrome Reflection", Range(0, 1)) = 0
[ToggleUI]
_MT_GeomSpecAA ("[MT] Geometric Specular AA", Range(0, 1)) = 1
[Enum(MASK,0,METALLIC,1)]
_MT_MetallicMapType ("[MT] MetallicMap Type", Float) = 0
[NoScaleOffset]
_MetallicGlossMap ("[MT] MetallicSmoothnessMap Texture", 2D) = "white" {}
[ToggleUI]
Expand Down Expand Up @@ -158,7 +156,7 @@ Shader "UnlitWF/Custom/WF_UnToon_Custom_ClearCoat_Addition" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_Category ("BRP|UnToon|Custom/ClearCoat|Addition", Float) = 0
Expand Down
18 changes: 2 additions & 16 deletions Shaders/Unlit_WF_UnToon_Custom_ClearCoat_Opaque.shader
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,6 @@ Shader "UnlitWF/Custom/WF_UnToon_Custom_ClearCoat_Opaque" {
[HDR]
_BKT_BackColor ("[BKT] Back Color", Color) = (1, 1, 1, 1)

[WFHeaderToggle(3ch Color Mask)]
_CHM_Enable ("[CHM] Enable", Float) = 0
[NoScaleOffset]
_CHM_3chMaskTex ("[CHM] 3ch Mask Texture", 2D) = "black" {}
[HDR]
_CHM_ColorR ("[CHM] R ch Color", Color) = (1, 1, 1, 1)
[HDR]
_CHM_ColorG ("[CHM] G ch Color", Color) = (1, 1, 1, 1)
[HDR]
_CHM_ColorB ("[CHM] B ch Color", Color) = (1, 1, 1, 1)

[WFHeaderToggle(Gradient Map)]
_CGR_Enable ("[CGR] Enable", Float) = 0
[NoScaleOffset]
Expand Down Expand Up @@ -108,8 +97,6 @@ Shader "UnlitWF/Custom/WF_UnToon_Custom_ClearCoat_Opaque" {
_MT_Monochrome ("[MT] Monochrome Reflection", Range(0, 1)) = 0
[ToggleUI]
_MT_GeomSpecAA ("[MT] Geometric Specular AA", Range(0, 1)) = 1
[Enum(MASK,0,METALLIC,1)]
_MT_MetallicMapType ("[MT] MetallicMap Type", Float) = 0
[NoScaleOffset]
_MetallicGlossMap ("[MT] MetallicSmoothnessMap Texture", 2D) = "white" {}
[ToggleUI]
Expand Down Expand Up @@ -250,7 +237,7 @@ Shader "UnlitWF/Custom/WF_UnToon_Custom_ClearCoat_Opaque" {
_TR_Enable ("[TR] Enable", Float) = 0
[HDR]
_TR_Color ("[TR] Rim Color", Color) = (0.8, 0.8, 0.8, 1)
[WF_Enum(UnlitWF.BlendModeTR,ADD,ALPHA,ADD_AND_SUB,MUL)]
[WF_Enum(UnlitWF.BlendModeTR,ADD,ALPHA,ADD_AND_SUB)]
_TR_BlendType ("[TR] Blend Type", Float) = 0
_TR_Width ("[TR] Width", Range(0, 1)) = 0.1
_TR_Feather ("[TR] Feather", Range(0, 1)) = 0.05
Expand Down Expand Up @@ -383,7 +370,7 @@ Shader "UnlitWF/Custom/WF_UnToon_Custom_ClearCoat_Opaque" {

[HideInInspector]
[WF_FixFloat(0.0)]
_CurrentVersion ("2024/04/07 (1.12.1)", Float) = 0
_CurrentVersion ("2024/05/25 (2.0.0)", Float) = 0
[HideInInspector]
[WF_FixFloat(0.0)]
_FallBack ("UnlitWF/UnToon_Mobile/WF_UnToon_Mobile_Opaque", Float) = 0
Expand Down Expand Up @@ -428,7 +415,6 @@ Shader "UnlitWF/Custom/WF_UnToon_Custom_ClearCoat_Opaque" {
#pragma shader_feature_local_fragment _ _ES_AULINK_ENABLE
#pragma shader_feature_local_fragment _ _TS_STEP1_ENABLE _TS_STEP2_ENABLE _TS_STEP3_ENABLE
#pragma shader_feature_local_fragment _BKT_ENABLE
#pragma shader_feature_local_fragment _CHM_ENABLE
#pragma shader_feature_local_fragment _CGR_ENABLE
#pragma shader_feature_local_fragment _CLC_ENABLE
#pragma shader_feature_local_fragment _DFD_ENABLE
Expand Down
Loading

0 comments on commit 02ce0f8

Please sign in to comment.