Replace the activationEvent "*" with "onStartupFinished" #1720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Start up ("*") activation point is generally not preferred and
onStartupFinished
is referred to as a better alternative.For example, another keybindings extension
vscode-sublime-keybindings
has switched its activation point from*
toonStartupFinished
: microsoft/vscode-sublime-keybindings#158Also, some built-in extensions have fixed this as well (, while some haven't with explicit decision to opt-in the "*"): microsoft/vscode#110031
The VsCodeVim extension follows this as well (VSCodeVim/Vim#8548)
For the version compatibility,
onStartupFinished
has been available since 1.46.0, so this change doesn't have a negative side effect on the supported version of this extension:vscode-emacs-mcx/package.json
Lines 11 to 13 in 04182e2