Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new US counties in CT, AK, and VA and rework related CT localadmin #207

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

nvkelso
Copy link
Contributor

@nvkelso nvkelso commented Aug 1, 2024

Fixes whosonfirst-data/whosonfirst-data#2197 (CT) and whosonfirst-data/whosonfirst-data#2136 (AK and VA).

  • 9 new CT counties don't cleanly map to 8 old CT counties (end them, no superseding), with populations
  • 169 existing CT localadmin need updated geoid concordances (because their parent chanaged), with pops
  • 2 new AK counties do cleanly map to 1 old AK county (supersede them), with pops
  • 1 revised VA county does cleanly map to 2 old VA county (supersede just the one, mod the remaining, alt geom it, too), with pops

Needs full PIP

@nvkelso nvkelso requested a review from stepps00 August 1, 2024 21:57
@nvkelso
Copy link
Contributor Author

nvkelso commented Aug 1, 2024

@stepps00 The commits in this PR should be fairly atomic and reviewable in sequence and in total.

For the counties I manually set the wof:hierarchy & etc, but really it needs a fuller PIP to account for all the child places in these counties (not just localadmin but also locality and neighbourhoods, etc).

@nvkelso
Copy link
Contributor Author

nvkelso commented Aug 1, 2024

I'll followup with a separate PR for the localadmin work outside of Connecticut as that affects many thousand places, but doesn't require PIP.

@nvkelso nvkelso changed the title [WIP] Add new US counties in CT, AK, and VA and rework related localadmin Add new US counties in CT, AK, and VA and rework related CT localadmin Aug 1, 2024
@nvkelso
Copy link
Contributor Author

nvkelso commented Aug 2, 2024

Connecticut

Old county records in black outlines (missing populations because expired geoid concordances), new counties in red with red text labels (with updated geoid concordances):

image

Existing localadmin get new geoid concordances and parent county_id hierarchies:

image

Alaska

New county records:

image

Virginia

Modified and retired county records for Bedford Co and Bedford City:

image

@nvkelso
Copy link
Contributor Author

nvkelso commented Aug 2, 2024

Followup outside of these new features in CT and AK for statistical gores is in #208.

@@ -2,7 +2,7 @@
"id": 102084283,
"type": "Feature",
"properties": {
"edtf:cessation":"uuuu",
"edtf:cessation":"2021-12-31",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and a few others should get an update to the wof:lastmodified date field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by re-exportifying everything!

@stepps00
Copy link
Contributor

stepps00 commented Aug 2, 2024

Looks good - a few comments, mostly around missing or unexpected properties. Once these features get Exportified and PIPd, I can take a second look before merge.

@nvkelso
Copy link
Contributor Author

nvkelso commented Aug 2, 2024

@stepps00 I've addressed your PR review comments and re-exportified everything. One more 👀 ?

Then I'll pick this up later for final PIP round.

@@ -242,7 +242,7 @@
"wof:lang": [
"eng"
],
"wof:lastmodified": 1722546126,
"wof:lastmodified": 1722625362,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. looks like this feature hasn't been updated, aside from this property?

@@ -484,7 +484,7 @@
}
],
"wof:id": 1125864515,
"wof:lastmodified": 1722545441,
"wof:lastmodified": 1722625363,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue, this feature only has the lastmodified date edited.

@stepps00
Copy link
Contributor

stepps00 commented Aug 2, 2024

A few records only have lastmodified date updates.. aside from that, LGTM. I can take another look once the PIP work is added.

@ashah-lightbox
Copy link

@stepps00 Any updates?

@nvkelso
Copy link
Contributor Author

nvkelso commented Sep 12, 2024

The next step here is to PIP update the hierarchy and parent attributes. I haven't had time to do that yet...

@ashah-lightbox
Copy link

@nvkelso just curious what do you mean by PIP update?

@tfeathers
Copy link

@nvkelso @stepps00

Is there an established process to do the PIP work? Is there anything we can do to help complete the hierarchies and get this PR over the finish line?

@nvkelso
Copy link
Contributor Author

nvkelso commented Nov 14, 2024

PIP means "point in polygon" and is PIPing is the process of taking the revgeo centroid, or the label centroid, or the math centroid and doing a spatial join with all the possible parent polygons to then update the wof:hierarchy properties.

We used to have a semi-automated workflow for PIPing, but we're more low fi now.

@thisisaaronland described how this can be accomplished using modern workflow in blog post, but I haven't found time to get that up and running on my new dev machine.

There's some WOF specific business logic for the hierarchy calculations... else you could manually run the PIP in QGIS with a and with a little bit of scripting construct the new message and update each record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

US: New Connecticut "county" records
4 participants