Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Herty/start with filter #832

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Herty/start with filter #832

wants to merge 6 commits into from

Conversation

Herty94
Copy link

@Herty94 Herty94 commented Oct 24, 2023

Resolves #617

But there is need to connect now static strings to translation library.

whyboris
whyboris requested changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@whyboris whyboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to undo the automated formatting / styling changes somehow?

All the ' -> " changes as well as the others that auto-happened?

@Herty94
Copy link
Author

Herty94 commented Nov 5, 2023

Sorry for taking me so long. I hope I fixed all of the formatting changes. And I've added translation.

@Herty94 Herty94 mentioned this pull request Nov 6, 2023
Open
@whyboris
Copy link
Owner

whyboris commented Nov 9, 2023

Hey @Herty94 - thank you for this clean PR contribution 🙇 ❤️
I'm eager to get back to VHA development in the coming months (still working on rebuilding my kitchen in the house). This PR will be merged in before the next release 👍 😁 👍
I'll test it out locally before merging; if there's any small thing to adjust I'll do it after the merge -- looking at the code without running seems like it's 💯 ready 🚀
Great work - thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyboris whyboris whyboris requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "starts with" search filter
2 participants
@Herty94 @whyboris