Skip to content

Commit

Permalink
feat: show number of widgets created and close when using --timing
Browse files Browse the repository at this point in the history
  • Loading branch information
maartenbreddels committed Nov 22, 2023
1 parent 8d2364b commit 6776134
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
7 changes: 4 additions & 3 deletions solara/server/patch.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ def Thread_debug_run(self):
_patched = False
global_widgets_dict = {}
global_templates_dict: Dict[Any, Any] = {}
widgets = context_dict_widgets()


def Output_enter(self):
Expand Down Expand Up @@ -314,14 +315,14 @@ def patch():

if ipywidget_version_major < 8:
global_widgets_dict = ipywidgets.widget.Widget.widgets
ipywidgets.widget.Widget.widgets = context_dict_widgets() # type: ignore
ipywidgets.widget.Widget.widgets = widgets # type: ignore
else:
if hasattr(ipywidgets.widgets.widget, "_instances"): # since 8.0.3
global_widgets_dict = ipywidgets.widgets.widget._instances
ipywidgets.widgets.widget._instances = context_dict_widgets() # type: ignore
ipywidgets.widgets.widget._instances = widgets # type: ignore
elif hasattr(ipywidgets.widget.Widget, "_instances"):
global_widgets_dict = ipywidgets.widget.Widget._instances
ipywidgets.widget.Widget._instances = context_dict_widgets() # type: ignore
ipywidgets.widget.Widget._instances = widgets # type: ignore
else:
raise RuntimeError("Could not find _instances on ipywidgets version %r" % ipywidgets.__version__)
threading.Thread.__init__ = WidgetContextAwareThread__init__ # type: ignore
Expand Down
12 changes: 10 additions & 2 deletions solara/server/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import solara
import solara.routing

from . import app, jupytertools, settings, websocket
from . import app, jupytertools, patch, settings, websocket
from .kernel import Kernel, deserialize_binary_message
from .kernel_context import initialize_virtual_kernel

Expand Down Expand Up @@ -135,6 +135,8 @@ async def app_loop(ws: websocket.WebsocketWrapper, session_id: str, kernel_id: s
solara_user.set(user)

while True:
if settings.main.timing:
widgets_ids = set(patch.widgets)
try:
message = await ws.receive()
except websocket.WebSocketDisconnect:
Expand All @@ -156,7 +158,13 @@ async def app_loop(ws: websocket.WebsocketWrapper, session_id: str, kernel_id: s
return
t2 = time.time()
if settings.main.timing:
print(f"timing: total={t2-t0:.3f}s, deserialize={t1-t0:.3f}s, kernel={t2-t1:.3f}s") # noqa: T201
widgets_ids_after = set(patch.widgets)
created_widgets_count = len(widgets_ids_after - widgets_ids)
close_widgets_count = len(widgets_ids - widgets_ids_after)
print( # noqa: T201
f"timing: total={t2-t0:.3f}s, deserialize={t1-t0:.3f}s, kernel={t2-t1:.3f}s"
f" widget: created: {created_widgets_count} closed: {close_widgets_count}"
)
finally:
context.page_disconnect(page_id)

Expand Down

0 comments on commit 6776134

Please sign in to comment.