Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support Layout when specifying routes #554

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix: support Layout when specifying routes #554

merged 1 commit into from
Mar 19, 2024

Conversation

maartenbreddels
Copy link
Contributor

Before, if we specified

routes = [
    solara.Route(path="/", component=Home, label="Home", layout=Layout),
    solara.Route(path="about", component=About, label="About"),
]

We would not render the the page and layout correcly.

@maartenbreddels Graphite App
Copy link
Contributor Author

maartenbreddels commented Mar 13, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maartenbreddels and the rest of your teammates on Graphite Graphite

@maartenbreddels maartenbreddels force-pushed the 03-13-fix_layout_when_using_routes branch from 0b25590 to e3a2107 Compare March 13, 2024 15:55
@maartenbreddels maartenbreddels mentioned this pull request Mar 13, 2024
Merged
@maartenbreddels maartenbreddels force-pushed the 03-13-fix_layout_when_using_routes branch from e3a2107 to df40333 Compare March 19, 2024 14:26
@maartenbreddels Graphite App
Copy link
Contributor Author

maartenbreddels commented Mar 19, 2024 •
edited
Loading

Merge activity

@maartenbreddels maartenbreddels merged commit 4d17086 into master Mar 19, 2024
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maartenbreddels