fix: on_kernel_start callbacks accumulated after hot reload #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maartenbreddels and the rest of your teammates on |
maartenbreddels
force-pushed
the
03-14-fix_on_kernel_start_callbacks_acculumated_after_hot_reload
branch
from
078c4d2
to
9e74190
Compare
maartenbreddels
force-pushed
the
03-14-fix_on_kernel_start_callbacks_acculumated_after_hot_reload
branch
4 times, most recently
from
5c4d2b2
to
47967f9
Compare
Introduced in #471 We should remove the on_kernel_start callbacks on a hot reload, but not remove the ones added by the hot reload itself.
maartenbreddels
force-pushed
the
03-14-fix_on_kernel_start_callbacks_acculumated_after_hot_reload
branch
from
47967f9
to
bc84a1f
Compare
|
Your Render PR Server URL is https://solara-stable-pr-556.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-co0ma3779t8c73f3092g. |
maartenbreddels
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #471
We should remove the on_kernel_start callbacks on a hot reload, but
not remove the ones added by the hot reload itself.
TODO: What happens when we import packages that are in site-packages that will not be reloaded?