feat: add user_ns to our ipython replacement #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for widgetti/glue-solara#6 to work properly. Otherwise glue cleanup method (https://github.com/glue-viz/glue/blob/e7c2766d85aceea29aae1a51d95d1189f4444b55/glue/viewers/common/viewer.py#L426-L430) fails.
maartenbreddels
temporarily deployed
to
10-11-feat_add_user_ns_to_our_ipython_replacement - solara-stable PR #812
Render
Destroyed
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @iisakkirotko and the rest of your teammates on |
iisakkirotko
added a commit
to widgetti/glue-solara
that referenced
this pull request
Oct 16, 2024
* feat: closing viewer mdi windows * chore: restrict solara to version >=1.40.0 We need at least version 1.40.0, since widgetti/solara#812 is needed for closing viewers to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for widgetti/glue-solara#6 to work properly. Otherwise glue cleanup method (https://github.com/glue-viz/glue/blob/e7c2766d85aceea29aae1a51d95d1189f4444b55/glue/viewers/common/viewer.py#L426-L430) fails.