Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated networkmanager phishing scenario to support Windows Enterpris… #1256

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

ParisPantoulas
Copy link
Contributor

…e networks.

@sophron
Copy link
Member

sophron commented Jan 28, 2020

This is the continuation of #1242. I will review soon.

wifiphisher/data/phishing-pages/wifi_connect/config.ini Outdated Show resolved Hide resolved
@@ -43,7 +43,7 @@
color: white;
}

.mac-wifi .password input:focus + .glow {
.mac-wifi .password + .glow {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of this css (input:focus) you couldn't click(and then type) on the password field of mac enterprise networks. The cursor would stay permanently on the first field.

@sophron
Copy link
Member

sophron commented Mar 27, 2020

Hi @ParisPantoulas,

Let me know when this PR is ready for a new review.

@ParisPantoulas
Copy link
Contributor Author

I have made the changes you asked for. So i think it is ready for a new review.

@sophron
Copy link
Member

sophron commented Apr 13, 2020

Tested this with Chrome on Android, Firefox on Kali Linux and Chrome on MacOS and I received the same network manager which was for iOS.

@sophron
Copy link
Member

sophron commented Jan 12, 2022

Tested on MacOS. See below.

image

The text is different. In the original network manager, the text says "requires WPA-2 enterprise credentials." Also, The check-boxes are not properly aligned. Finally, the "help" question mark should be on the bottom left corner.

Please ensure that the network manager window is identical to the original.

Note that I have not tested the Windows network manager yet. If there are similar issues on Windows network manager too, please fix them there too.

# The variable enterprise is used when we are working with Windows enterprise network
# enterprise = 1 : we show the form for login of enterprise networks to the victim
# enterprise = 0 : we show the form for login of the non-enterprise networks to the victim
enterprise: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should remain "0" for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I changed the enterprise value back to 0.

  2. Also, I made changes to fix issues like in the image above in both MacOS and Windows.

@sophron
Copy link
Member

sophron commented Jan 12, 2022

I'm confused with the way you've named your files. I see "mac-network-manager-Safari.css" but then I see "opera-style.css". Is the "opera-style.css" OS-agnostic or is it for Windows systems only?

Pick a naming convention and use that for all of your HTML/CSS/JS files. For example, --.css where can be either "online" or "offline".

New contributors that want to improve the scenario should be able to find easily the file they need to work with.

@ParisPantoulas
Copy link
Contributor Author

I'm confused with the way you've named your files. I see "mac-network-manager-Safari.css" but then I see "opera-style.css". Is the "opera-style.css" OS-agnostic or is it for Windows systems only?

Pick a naming convention and use that for all of your HTML/CSS/JS files. For example, --.css where can be either "online" or "offline".

New contributors that want to improve the scenario should be able to find easily the file they need to work with.

I renamed the files in order to be more specific.
In the first place i needed to create a different css file for every network manager and for that reason there are all these css files.
The xxx-offline.css files are used in both Windows and MacOS and the xxx-network-manager-xxx.css files are used for the network managers.

For example:

  • chrome-offline.css is used in both Windows and MacOS for the Chrome browser.
  • windows-network-manager-Chrome.css is used for the network manager of Chrome browser in Windows.
  • mac-network-manager-Chrome.css is used for the network manager of Chrome browser in MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants