Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Better codebase structure #167

Merged
merged 36 commits into from
Oct 24, 2020

Conversation

wildan3105
Copy link
Owner

@wildan3105 wildan3105 commented Oct 3, 2020

Description

Partially resolves #166

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Codebase refactoring

Screenshot of change (if there's UI update)

ISSUES

  • Favicon is not loaded properly
  • Back to home font is a bit weird (black)

ONLY WILL MERGE THIS AFTER THESE PRS ARE ALREADY MERGED:

@wildan3105 wildan3105 added this to the Refactoring codebase milestone Oct 3, 2020
@wildan3105 wildan3105 self-assigned this Oct 4, 2020
@wildan3105 wildan3105 marked this pull request as ready for review October 5, 2020 04:04
@wildan3105
Copy link
Owner Author

UPDATE
Only first phase, next phase is to remove all github api call to src/api/service.js

@wildan3105 wildan3105 merged commit 1ef69ad into master Oct 24, 2020
@wildan3105 wildan3105 deleted the refactor/improve-codebase-structure branch August 18, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better code structure
1 participant