Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The UI hangs on some content in album/song titles #33

Open
xxxserxxx opened this issue Mar 10, 2023 · 0 comments
Open

The UI hangs on some content in album/song titles #33

xxxserxxx opened this issue Mar 10, 2023 · 0 comments

Comments

@xxxserxxx
Copy link
Contributor

I've encountered an error when scrolling through my artist list: rapidly scrolling (key repeat) through the authors, the UI would hang at points. Music that was playing would continue to play, and the program would still respond to mpris commands, but the UI would be completely frozen.

At first, I thought this was due to a thread-lock issue in the UI, because sections of the code were not thread-safe (and, hence, the threadsafe PR), but even with that patch, the problem persisted. I added context.WithTimeout in a couple of places and discovered that the hangs were happening only on specific artists. I'm still debugging what triggers the hang, but it is looking like some titles may be causing tview heartburn. When I finally figure it out, I'll submit a patch, and when I do, this is the ticket that it will fix. I'll also answer what content is triggering the hang.

It's possible as well that the issue is not in tview, but in the Subsonic API client code. The server is unaffected, so it's def. on the client side. My bet is on it being a tview issue, though. We'll see.

@xxxserxxx xxxserxxx mentioned this issue Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant