Fixes #33 #34
Closed
Fixes #33 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And, I'm going to rebase this, so I'm closing this one, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go to 1.19, to get context; add timeout to getResponse to prevent hangs. Fixes #33.
Calls to the server via
SubSonicConnection.getResponse()can hang indefinitely. Because UI events can callgetResponse, if the call hangs, so does the UI.This change adds a timeout context to
getResponse, allowing the call to time out and return, and preventing UI hangs. While it may not resolve the server call issue, it does allow users to switch to the log panel and possibly see errors, and also allows users to cleanly exit the program (withq).