Added setting to allow rerate deleted of the same score to address … #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jamesoutterside
commented
Apr 1, 2020
•
jamesoutterside
commented
- Added STAR_RATINGS_RERATE_SAME_DELETE setting for unvote voted object #75
- Deletes the object, still returns the rating.
- Tweaked the JS so it goes back to the initial/default state.
- System check in case user sets it with STAR_RATINGS_RERATE disabled.
OmegaDroid
approved these changes
Apr 3, 2020
| @@ -13,3 +13,6 @@ def ready(self): | |||
|
|
|||
| post_save.connect(calculate_ratings, sender=UserRating) | |||
| post_delete.connect(calculate_ratings, sender=UserRating) | |||
|
|
|||
| # Add System checks | |||
| from .checks import rerate_check # NOQA | |||
There was a problem hiding this comment.
Personally I would prefer calling register in here rather than having a decorator to avoid the side effect on importing similar to how we handle the signals above
There was a problem hiding this comment.
👍 makes sense.
There was a problem hiding this comment.
FYI, I've updated and am resolving conflicts then will merge down
Codecov Report
@@ Coverage Diff @@
## develop #188 +/- ##
===========================================
+ Coverage 98.25% 98.38% +0.12%
===========================================
Files 13 14 +1
Lines 287 309 +22
===========================================
+ Hits 282 304 +22
Misses 5 5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.