add Administration.shutdownGracefully #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm currently not sure if this is a proper way of supporting graceful shutdown in Creaper, so I'm going to leave the pull request open for some time for review. CC @rhatlapa. |
|
LGTM, maybe also some tests might be added, mainly some tests which would make sure it doesn't get broken for the older versions of the WildFly/AS7 servers (no-one will remove or forget to have proper handling for |
|
Tests are definitely missing, thanks for the notice. |
|
Added a test. The new commits are supposed to be squashed. |
|
Thanks, LGTM. |
Ladicek
force-pushed
the
graceful-shutdown
branch
2 times, most recently
from
c5b9871 to
3ea91d3
Compare
Ladicek
force-pushed
the
graceful-shutdown
branch
from
3ea91d3 to
0788724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125.