Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#239] Generate GRPC model reference #240

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmesnil
Copy link
Member

@jmesnil jmesnil commented Jun 5, 2024

  • Use the Maven plug-in for Wildscribe to generate the Model reference for the org.wildfly.extension.grpc extension

This fixes #239

* Use the Maven plug-in for Wildscribe to generate the Model reference for the org.wildfly.extension.grpc extension

This fixes wildfly-extras#239

Signed-off-by: Jeff Mesnil <[email protected]>
@jmesnil jmesnil requested a review from hpehl as a code owner June 5, 2024 07:43
@jmesnil jmesnil marked this pull request as draft June 5, 2024 07:43
@jmesnil
Copy link
Member Author

jmesnil commented Jun 5, 2024

@hpehl Hi, this is a draft as the generated output of wildscribe is not great: it contains the grpc subsystem as well as other extension from WildFly.

If this RFE is something that would interest you, we can update wildscribe so that it only outputs the model reference for certain path address (eg /subsystem=grpc, /deployment=*/subsystem=grpc & /deployment=*/subdeployment=*/subsystem=grpc)

<required-extensions>
<required-extension>org.wildfly.extension.grpc</required-extension>
</required-extensions>
</configuration>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once wildscribe/wildscribe#71 has been implemented, the <path-addresses> element would be added here, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate the Model Reference for the GRPC extension
2 participants