Cleanup Core Profle TCK runner #58
Conversation
Signed-off-by: Scott Marlow <[email protected]>
Signed-off-by: Scott Marlow <[email protected]>
| # locate SPEC API jars if not already specified | ||
| if [[ -z "${ANNOTATION_API}" ]]; then | ||
| pushd ${JBOSS_HOME} | ||
| export ANNOTATION_API=`find * -name jakarta*annotation*api*.jar` |
There was a problem hiding this comment.
Does this work with the embedded \n new lines?
There was a problem hiding this comment.
which \n new lines do you mean?
There was a problem hiding this comment.
When you do a find it will print each found file on a new line. You'd end up with the environment variable looking something like:
ANNOTATION_API=some/path/cool.jar
some/path/other.jar
some/path/another.jar
I would think only the first one, cool.jar in the example, would be seen.
There was a problem hiding this comment.
If multiple jars match the pattern than we need to update the find expression. That sounds like a condition we should check for
There was a problem hiding this comment.
Ah, I guess all these do just return a single JAR. Maybe something we more need to keep an eye on then.
There was a problem hiding this comment.
Agreed and the run will fail with an error if we introduce additional jars that have similar names such that more than one line is in the result.
Signed-off-by: Scott Marlow <[email protected]>
|
Are we ready to merge this PR or do we need more changes? |
|
Could we merge this change as It seems like this change helps avoid some Core Profile 10 failures. Testing without this pr:
Testing with this pr:
|
|
We still need to understand why |
|
Thanks @scottmarlow |
#57