Skip to content

Commit

Permalink
Script location
Browse files Browse the repository at this point in the history
  • Loading branch information
@stuartkmarsh
stuartkmarsh committed Mar 7, 2019
1 parent ef45864 commit fc9f7bc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dataplicity/device_meta.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# Cache the meta dict because it never changes
_META_CACHE = None

TAG_SCRIPT = "/opt/dataplicity/tuxtunnel/taglist.sh"
TAG_SCRIPT = "/home/dataplicity/dataplicity.tags.sh"


def get_meta():
Expand Down

7 comments on commit fc9f7bc

@willmcgugan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you add the extension? Users might not want to use a bash file.

@barfle
Copy link
Contributor

@barfle barfle commented on fc9f7bc Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. Indicates to the user how we are executing it. If they don't want to use bash they could always call it from elsewhere. I think the only question is would most people here prefer a basic shell or would they prefer something higher level like python?

@willmcgugan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They could use any language really, since it will respect the hashbang. But its a bit weird if its called something.sh and it really contains Python.

@barfle
Copy link
Contributor

@barfle barfle commented on fc9f7bc Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK point made. Lose the extension

@willmcgugan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just call it tags then? @beardygeek You might want to check that it will fail gracefully if no tags are present, or its not executable, etc.

@barfle
Copy link
Contributor

@barfle barfle commented on fc9f7bc Mar 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I do want dataplicity in the fikename. It matches what we do for custom actions but also distinguishes it from anything else the user might put there

@willmcgugan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, dataplicity_tags then? I figured that dataplcitiy.tags might leave the user wondering what the tags extensions means.

Please sign in to comment.