feat: update is_on check to string and readme #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D-nDev
force-pushed
the
feat/FPV-1581-add-new-values-to-is-on-not-boolean
branch
from
84cc416 to
7f78611
Compare
deroldo
reviewed
Nov 6, 2024
D-nDev
force-pushed
the
feat/FPV-1581-add-new-values-to-is-on-not-boolean
branch
from
7f78611 to
a38eca9
Compare
deroldo
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Make is_on more explicity return false for string values
Proposed changes
Add OFF as option to return false in is_on and update readme to be more explicity