-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a paging factory (KnpPaginatorFactory) for users of the paginator components of KNP -components #225
base: master
Are you sure you want to change the base?
Conversation
Is this lib still maintained? |
this lib is maintained by KnpLabs. On symfony bundle it exist KnpPaginatorBundle based on this lib |
Alright. So let's fix the tests first, and then squash the commits so that we can get this merged :) |
@@ -26,7 +26,9 @@ | |||
"symfony/routing": "~2.0 || ~3.0", | |||
"symfony/dependency-injection": "~2.0 || ~3.0", | |||
"pagerfanta/pagerfanta": "~1.0", | |||
"twig/twig": "~1.12" | |||
"twig/twig": "~1.12", | |||
"symfony/event-dispatcher": "~2.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sf 3?
Looks good! This can be helpful for the timeline bundle that ships with knp paginator support: https://github.com/stephpy/timeline-bundle/blob/master/Resources/doc/pagination.markdown |
I saw a issue that talked about how to integrate knp paginator to create a representation of collection. Now it is true that it is not very useful on this library. Thank you I will rather create a gist |
hi, @skineur what is the issue you're talking about? why this hasn't been merged? I would found it quite useful |
@@ -26,7 +26,9 @@ | |||
"symfony/routing": "~2.0 || ~3.0", | |||
"symfony/dependency-injection": "~2.0 || ~3.0", | |||
"pagerfanta/pagerfanta": "~1.0", | |||
"twig/twig": "~1.12" | |||
"twig/twig": "~1.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about twig 2?
How to use with Knp-Components Pager