Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iOS OneSignal SDK to 3.12.3 #113

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ com.williamrijksen.onesignal-*.zip

# dependency directories
ios/Carthage/
ios/dist/
8 changes: 6 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ Before setting up the Titanium SDK, you must generate the appropriate credential

```xml
<modules>
<module platform="iphone" version="2.1.1">com.williamrijksen.onesignal</module>
<module platform="android" version="2.1.1">com.williamrijksen.onesignal</module>
<module platform="iphone">com.williamrijksen.onesignal</module>
<module platform="android">com.williamrijksen.onesignal</module>
</modules>
```
1. Configure your app into the App Settings panel for the right Platform (Android and/or iOS).
Expand All @@ -41,6 +41,10 @@ Before setting up the Titanium SDK, you must generate the appropriate credential
- [https://documentation.onesignal.com/docs/ios-sdk-setup#section-1-add-notification-service-extension](https://documentation.onesignal.com/docs/ios-sdk-setup#section-1-add-notification-service-extension)
- [http://docs.appcelerator.com/platform/latest/#!/guide/Creating_iOS_Extensions_-_Siri_Intents](http://docs.appcelerator.com/platform/latest/#!/guide/Creating_iOS_Extensions_-_Siri_Intents)

#### Android

If you have some build errors about Google Play service dependencies you will need to add `googleServices {disableVersionCheck = true}` to your build.gradle file.

### Usage
1. Register device for Push Notifications

Expand Down
15 changes: 15 additions & 0 deletions android/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
buildscript {
repositories {
mavenCentral()
gradlePluginPortal()
}
dependencies {
classpath 'gradle.plugin.com.onesignal:onesignal-gradle-plugin:[0.12.10, 0.99.99]'
}
}

dependencies {
// Add the module's library dependencies here.
// See: https://developer.android.com/studio/build/dependencies
implementation 'com.onesignal:OneSignal:[4.0.0, 4.99.99]'
}
Binary file removed android/lib/OneSignalSDK.jar
Binary file not shown.
6 changes: 3 additions & 3 deletions android/manifest
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# this is your module manifest and used by Titanium
# during compilation, packaging, distribution, etc.
#
#
#

version: 2.1.2
version: 3.0.1
apiversion: 4
architectures: arm64-v8a armeabi-v7a x86
description: com.williamrijksen.onesignal
Expand All @@ -17,4 +17,4 @@ name: com.williamrijksen.onesignal
moduleid: com.williamrijksen.onesignal
guid: 67065763-fd5e-4069-a877-6c7fd328f877
platform: android
minsdk: 8.3.1.GA
minsdk: 9.3.2.GA
Loading