ws color: separate logic from reactivity condition (#5046)

* fix workspace color picker issue * removing useless reactive statement * some ui fixes * separate logic from reactivity condition
windmill-labs · Jan 10, 2025 · 03450bd · 03450bd
1 parent 089e698
commit 03450bd
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/frontend/src/lib/components/settings/ChangeWorkspaceColor.svelte b/frontend/src/lib/components/settings/ChangeWorkspaceColor.svelte
@@ -14,9 +14,11 @@
 
 	export let open = false
 
-	$: if ($usersWorkspaceStore && $workspaceStore !== lastWorkspace) {
+	$: $usersWorkspaceStore && $workspaceStore !== lastWorkspace && onWorkspaceChange()
+
+	function onWorkspaceChange() {
 		lastWorkspace = $workspaceStore
-		savedWorkspaceColor = $usersWorkspaceStore.workspaces.find(
+		savedWorkspaceColor = $usersWorkspaceStore?.workspaces.find(
 			(w) => w.id === $workspaceStore
 		)?.color
 		workspaceColor = savedWorkspaceColor