give option to run container as non-root windmill user

[alpetric]

uid/gid 1000:1000

---

Important

Add option to run container as non-root 'windmill' user and update volume paths in Docker and Terraform configurations.

• Dockerfile:
  • Adds non-root user 'windmill' with UID/GID 1000.
  • Copies cache from /root/.cache to /home/windmill/.cache.
  • Adjusts ownership of ${APP}, /tmp/windmill, and /home/windmill/.cache to 'windmill'.
• docker-compose.yml:
  • Changes volume path from /root/.cache to /pyls/.cache for lsp service.
• Terraform (windmill_lsp.tf):
  • Updates host_path for lsp_cache volume to /pyls/.cache.
• lsp/Dockerfile:
  • Sets WORKDIR to /pyls and ensures permissions for all users.
  • Installs necessary packages and sets up environment for pyls service.

^{This description was created by for af1efd6. It will automatically update as commits are pushed.}

[cloudflare-workers-and-pages]

Deploying windmill with    Cloudflare Pages

Latest commit:	3d89c0c
Status:	✅  Deploy successful!
Preview URL:	https://272b48ec.windmill.pages.dev
Branch Preview URL:	https://alp-docker-non-root.windmill.pages.dev

View logs

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 5d71040 in 52 seconds

More details

• Looked at 86 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. lsp/Dockerfile:54

• Draft comment:
  Setting the user back to root after creating a non-root user defeats the purpose of running the container as a non-root user. Consider removing this line to enhance security.
• Reason this comment was not posted:
  Marked as duplicate.

2. Dockerfile:203

• Draft comment:
  Copying files from /root/.cache to /home/windmill/.cache assumes that the cache directory exists and is accessible. Ensure that /root/.cache exists before copying to avoid potential errors.
• Reason this comment was not posted:
  Comment did not seem useful.

3. docker-compose.yml:146

• Draft comment:
  The key pull_policy should be pull_policy. This typo appears in multiple places (lines 28, 46, 73, 96, 121).
• Reason this comment was not posted:
  Comment was not on a valid diff hunk.

Workflow ID: wflow_79ToDRyLSx5QiGfq

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on af1efd6 in 8 seconds

More details

• Looked at 24 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. lsp/Dockerfile:62

• Draft comment:
  The CMD line is unnecessarily complex. Consider simplifying it for better readability and maintainability. For example, you can separate the logic into a shell script and call the script from CMD.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The CMD line is unnecessarily complex and could be simplified for better readability and maintainability.

Workflow ID: wflow_JkoVDoyVKuo36fFj

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[alpetric]

@rubenfiszel tested last commit both with root / non_root and it works both with the old /root/.cache mount and the /pyls/.cache mount