Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update nix flake #4998

Merged
merged 1 commit into from
Jan 3, 2025
Merged

build: update nix flake #4998

merged 1 commit into from
Jan 3, 2025

Conversation

uael
Copy link
Collaborator

@uael uael commented Dec 31, 2024

  • update lock file
  • improve npm client package using pkgs.buildNpmPackage
  • improve windmill package

Important

Update Nix flake to enhance npm and Rust package builds, including lock file updates and new build inputs.

  • Lock File Update:
    • Update flake.lock with new revisions and hashes for nixpkgs and rust-overlay.
  • NPM Client Package:
    • Use pkgs.buildNpmPackage for windmill-client in flake.nix.
    • Add npmDepsHash and npmBuild for build process.
    • Modify postUnpack and preBuild phases.
  • Windmill Package:
    • Update buildFeatures in flake.nix to include new features like enterprise, stripe, prometheus, etc.
    • Add RUSTY_V8_ARCHIVE and FRONTEND_BUILD_DIR environment variables.
  • Build Inputs:
    • Add libtool to buildInputs in flake.nix.
    • Include self.packages.${system}.windmill-client and pkgs.perl in nativeBuildInputs for windmill.

This description was created by Ellipsis for 628fc9b. It will automatically update as commits are pushed.

- update lock file
- improve npm client package using `pkgs.buildNpmPackage`
- improve windmill package
@uael uael requested a review from rubenfiszel as a code owner December 31, 2024 07:20
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 628fc9b in 39 seconds

More details
  • Looked at 176 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. flake.nix:40
  • Draft comment:
    Using pkgs.lib.fakeHash for x86_64-darwin is not recommended. Consider using a valid hash or add a comment explaining the use of a fake hash.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    Using fakeHash is generally a temporary solution that needs to be replaced with a real hash. However, this could be intentional - perhaps the x86_64-darwin build isn't supported yet or the hash will be filled in later. The comment doesn't provide strong evidence that this is definitely wrong, just that it's not recommended.
    I might be too quick to dismiss this - using fakeHash could cause build failures on x86_64-darwin systems. The comment could help prevent issues.
    While build failures are possible, the author likely knows this is a placeholder. The comment doesn't provide actionable guidance on what the correct hash should be, and the use of fakeHash may be intentional during development.
    The comment should be deleted as it's more of a suggestion than a clear issue requiring change, and the use of fakeHash may be intentional.
2. flake.nix:114
  • Draft comment:
    doCheck is set to false, which disables tests. Ensure this is intentional to avoid missing potential issues. This applies to other instances as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The doCheck attribute is set to false in multiple places. This might be intentional, but it's worth noting that it disables tests, which could lead to undetected issues.
3. flake.nix:140
  • Draft comment:
    Ensure buildInputs and nativeBuildInputs are correctly categorized to avoid build issues. Check for any overlap or misplacement of dependencies.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The buildInputs and nativeBuildInputs are defined separately, but there might be overlap. It's important to ensure that dependencies are correctly categorized to avoid build issues.

Workflow ID: wflow_2g39ycYtUpawHcmB


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 628fc9b
Status: ✅  Deploy successful!
Preview URL: https://0a3be788.windmill.pages.dev
Branch Preview URL: https://uael-update-nix.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit 0ee7c9e into main Jan 3, 2025
2 checks passed
@rubenfiszel rubenfiszel deleted the uael/update_nix branch January 3, 2025 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants