Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive slack improvements #5001

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Conversation

alpetric
Copy link
Contributor

@alpetric alpetric commented Dec 31, 2024

  • dynamic default args
  • dynamic enums
  • add more details in description

Important

Enhance Slack approval process with dynamic default arguments and enums, and improve message details across backend, Python, and TypeScript clients.

  • Backend:
    • Added default_args_json and dynamic_enum_json handling in slack_approvals.rs for dynamic defaults and enums.
    • Updated request_slack_approval and slack_app_callback_handler to process new query parameters.
    • Enhanced create_input_block to support dynamic defaults and enums.
  • Python Client:
    • Updated request_interactive_slack_approval in client.py to accept default_args_json and dynamic_enum_json.
  • TypeScript Client:
    • Modified requestInteractiveSlackApproval in client.ts to handle defaultArgsJson and dynamicEnumJson.
    • Added SlackApprovalOptions interface to define new parameters.

This description was created by Ellipsis for 718512c. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 718512c in 1 minute and 52 seconds

More details
  • Looked at 1018 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. backend/windmill-api/src/slack_approvals.rs:889
  • Draft comment:
    Ensure default_args_json and dynamic_enum_json are valid JSON strings before adding them to the payload. Consider using serde_json::from_str to validate them.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. python-client/wmill/wmill/client.py:663
  • Draft comment:
    Ensure default_args_json and dynamic_enum_json are valid JSON objects before converting them to strings. Consider using json.dumps with error handling.
  • Reason this comment was not posted:
    Marked as duplicate.
3. typescript-client/client.ts:903
  • Draft comment:
    Ensure defaultArgsJson and dynamicEnumJson are valid JSON objects before converting them to strings. Consider using JSON.stringify with error handling.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_n1lsqeTKjzpehKJy


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 718512c
Status: ✅  Deploy successful!
Preview URL: https://7808ea05.windmill.pages.dev
Branch Preview URL: https://alp-interactive-slack-improv.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit 2832b88 into main Jan 3, 2025
7 checks passed
@rubenfiszel rubenfiszel deleted the alp/interactive_slack_improvements branch January 3, 2025 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants