fix: show array type narrowing #5006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 13446ef in 56 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_S3u7AmDYrExoU2T3
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Deploying windmill with
|
| Latest commit: |
7e58954
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://59f3d44b.windmill.pages.dev |
| Branch Preview URL: | https://alp-allow-edit-array-type.windmill.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently narrowing a list/array input to be strings from an enum in the generated UI is not possible as documented below
https://www.windmill.dev/videos/advanced_parameters_enum.mp4
Important
Fix condition in
ArrayTypeNarrowing.svelteto enable array type narrowing to string enums in the UI.ArrayTypeNarrowing.svelteto show 'Items type' label and select whenitemsTypeis 'resource' andcanEditResourceTypeis true, or whenitemsTypeis not 'resource'.This description was created by
for 13446ef. It will automatically update as commits are pushed.