Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: always show flow meta data, append user provided msg #5026

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

alpetric
Copy link
Contributor

@alpetric alpetric commented Jan 6, 2025

Important

Enhance get_modal_blocks to always show flow metadata and append user-provided message if available.

  • Behavior:
    • In get_modal_blocks, always show flow metadata and append user-provided message if available.
  • Code Changes:
    • Rename fallback_message to message_str in get_modal_blocks.
    • Add logic to append custom message to message_str if provided.

This description was created by Ellipsis for e865545. It will automatically update as commits are pushed.

@alpetric alpetric requested a review from rubenfiszel as a code owner January 6, 2025 21:49
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e865545 in 11 seconds

More details
  • Looked at 25 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. backend/windmill-api/src/slack_approvals.rs:1036
  • Draft comment:
    Consider updating the comment to reflect that a custom message is appended if provided, for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the PR modifies how the message is constructed by appending a custom message if provided. This is a logical change and should be reflected in the code comments for clarity.

Workflow ID: wflow_kdz7hOwU2Tg1PJJ7


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: e865545
Status: ✅  Deploy successful!
Preview URL: https://fc889dd3.windmill.pages.dev
Branch Preview URL: https://alp-slack-nit.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit e47a3aa into main Jan 6, 2025
7 checks passed
@rubenfiszel rubenfiszel deleted the alp/slack_nit branch January 6, 2025 21:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants