doc link job labels #5028
Merged
doc link job labels #5028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ac00f83 in 12 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/runs/RunsFilter.svelte:274
- Draft comment:
Consider rephrasing the tooltip text for clarity:
<a href="https://www.windmill.dev/docs/core_concepts/monitor_past_and_future_runs#jobs-labels" target="_blank">Job Labels</a> are string values in the 'wm_labels' array field, used for easy filtering.
- Reason this comment was not posted:
Confidence changes required:10%
The PR adds a hyperlink to the tooltip for 'Label'. This is a good addition for user guidance, but the sentence structure can be improved for clarity.
Workflow ID: wflow_kFTtVMdW1IUrTF3i
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Deploying windmill with
|
| Latest commit: |
ac00f83
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6b45bc20.windmill.pages.dev |
| Branch Preview URL: | https://alp-run-label-filter.windmill.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Updated tooltip in
RunsFilter.svelteto include a hyperlink to job labels documentation.RunsFilter.svelteto include a hyperlink to job labels documentation athttps://www.windmill.dev/docs/core_concepts/monitor_past_and_future_runs#jobs-labels.This description was created by
for ac00f83. It will automatically update as commits are pushed.