-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): allow workspace admin to set workspace color #5032
Conversation
Deploying windmill with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 60a233f in 1 minute and 33 seconds
More details
- Looked at
868
lines of code in18
files - Skipped
0
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. frontend/src/lib/components/settings/ChangeWorkspaceColor.svelte:17
- Draft comment:
Consider moving thegenerateRandomColor
function to a shared utility file to avoid code duplication, as it is also used increate_workspace
. - Reason this comment was not posted:
Confidence changes required:50%
The functiongenerateRandomColor
is called twice in the code: once in thecreate_workspace
page and once in theChangeWorkspaceColor
component. This is a code duplication that can be avoided by moving the function to a shared utility file.
2. frontend/src/lib/components/sidebar/MenuButton.svelte:34
- Draft comment:
Ensure that thecolor
property is consistently used across components to maintain uniform styling based on workspace color. - Reason this comment was not posted:
Confidence changes required:20%
Thecolor
property is used in multiple components to style elements based on the workspace color. This is a good practice for maintaining consistent styling across the application.
3. frontend/src/lib/components/sidebar/WorkspaceMenu.svelte:63
- Draft comment:
Ensure that thecolor
property is consistently used across components to maintain uniform styling based on workspace color. - Reason this comment was not posted:
Confidence changes required:20%
Thecolor
property is used in multiple components to style elements based on the workspace color. This is a good practice for maintaining consistent styling across the application.
4. frontend/src/routes/(root)/(logged)/user/(user)/workspaces/+page.svelte:198
- Draft comment:
Ensure that thecolor
property is consistently used across components to maintain uniform styling based on workspace color. - Reason this comment was not posted:
Confidence changes required:20%
Thecolor
property is used in multiple components to style elements based on the workspace color. This is a good practice for maintaining consistent styling across the application.
5. frontend/src/routes/(root)/(logged)/workspace_settings/+page.svelte:822
- Draft comment:
Ensure that thecolor
property is consistently used across components to maintain uniform styling based on workspace color. - Reason this comment was not posted:
Confidence changes required:20%
Thecolor
property is used in multiple components to style elements based on the workspace color. This is a good practice for maintaining consistent styling across the application.
Workflow ID: wflow_NCfzMOb4p18GDZWp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 0b8c71a in 26 seconds
More details
- Looked at
31
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/lib/components/sidebar/MenuButton.svelte:34
- Draft comment:
Consider using a CSS class for setting the border color instead of inline styles for better maintainability and consistency. This applies to other inline styles as well. - Reason this comment was not posted:
Confidence changes required:50%
The comment should be placed on a line that is part of the diff.
Workflow ID: wflow_YuDhpL3Hm5ExUNWN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add feature for workspace admins to set and display workspace color, including backend API and frontend UI changes.
color
column toworkspace_settings
table via migration scripts.openapi.yaml
to includechange_workspace_color
endpoint.workspaces.rs
to handle color inWorkspace
,WorkspaceSettings
, andUserWorkspace
structs, and implementchange_workspace_color()
function.ChangeWorkspaceColor.svelte
component for color selection in workspace settings.MenuButton.svelte
andWorkspaceMenu.svelte
to display workspace color.create_workspace/+page.svelte
andworkspaces/+page.svelte
to include color selection during workspace creation and display.stores.ts
to include color inuserWorkspaces
store.This description was created by for 0b8c71a. It will automatically update as commits are pushed.