only load critical alerts modal once devops store is set #5034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to ec11c00 in 31 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_UU6EBPR8UbXED4tZ
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -289,7 +289,8 @@ | |||
| setContext('openSearchWithPrefilledText', openSearchModal) | |||
|
|
|||
| $: { | |||
| if ($enterpriseLicense && $workspaceStore && $userStore && ($devopsRole || $userStore.is_admin)) { | |||
| if ($enterpriseLicense && $workspaceStore && $userStore && $devopsRole !== undefined && ($devopsRole || $userStore.is_admin)) { | |||
| console.log('mountModal', $devopsRole, $userStore.is_admin) | |||
There was a problem hiding this comment.
Remove the console.log statement to keep the production code clean.
Suggested change
| console.log('mountModal', $devopsRole, $userStore.is_admin) | |
| // console.log('mountModal', $devopsRole, $userStore.is_admin) |
Deploying windmill with
|
| Latest commit: |
7837519
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1e192e27.windmill.pages.dev |
| Branch Preview URL: | https://alp-critical-alert-fix.windmill.pages.dev |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7837519 in 9 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/routes/(root)/(logged)/+layout.svelte:292
- Draft comment:
Removing theconsole.logstatement is a good practice for production code as it avoids unnecessary logging. - Reason this comment was not posted:
Confidence changes required:0%
The PR removes a console.log statement which is not necessary for production code. This is a good practice as it cleans up the code and avoids unnecessary logging.
Workflow ID: wflow_xQkh5uYvjGhf3IBp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modal was loading in too early before
$devopsRolewas set.The initial load of the modal would show the user to not have devops but workspace admin role and hence display unacknowledged critical alerts for that workspace. Since the badge is updated every 30s or when changing context (to workspace), it would refresh the badge.
Fix: we're only loading the modal once
$devopsRole !== undefinedImportant
Ensure critical alerts modal in
+layout.svelteloads only when$devopsRoleis defined.+layout.svelte, the critical alerts modal now loads only when$devopsRoleis defined and either$devopsRoleis true or$userStore.is_adminis true.This description was created by
for 7837519. It will automatically update as commits are pushed.